e1000-devel Mailing List for Formerly Intel Ethernet Drivers

Hi e1000/igb folks,
Reaching out about a compile time error with IGB driver, kernel 6.6, and trying to compile with -Werror

In the Intel side of the IGB source, there is a flush_scheduled_work() in igb_remove, which according
to git blame from the GitHub side has been there since 1.0.1

https://github.com/intel/ethernet-linux-igb/blame/d4658bb8811ea60deb8d3398e8682b64dc0e1f07/src/igb_main.c#L3429

This same flush is not present on the mainline driver: https://github.com/torvalds/linux/blame/master/drivers/net/ethernet/intel/igb/igb_main.c#L3860

This flush now produces a compile time warning, which turns into a failure with Werror

There was an announcement on LKML about this for in-tree users a while back, here: https://lore.kernel.org/all/499...@I-.../T/#u

Compiling without Werror and using the driver is just fine, but wanted to see if this issue has been raised before and if there was any harm in simply removing this call (As the mainline driver appears to be working just fine without it)?

Thanks,
Jon

In file included from ./include/linux/srcu.h:21,
                 from ./include/linux/notifier.h:16,
                 from ./arch/x86/include/asm/uprobes.h:13,
                 from ./include/linux/uprobes.h:49,
                 from ./include/linux/mm_types.h:16,
                 from ./include/linux/buildid.h:5,
                 from ./include/linux/module.h:14,
                 from /builddir/build/BUILD/igb-5.16.9/src/igb_main.c:4:
/builddir/build/BUILD/igb-5.16.9/src/igb_main.c: In function 'igb_remove':
./include/linux/workqueue.h:639:2: error: call to '__warn_flushing_systemwide_wq' declared with attribute warning: Please avoid flushing system-wide workqueues. [-Werror]
  __warn_flushing_systemwide_wq();    \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/builddir/build/BUILD/igb-5.16.9/src/igb_main.c:3431:2: note: in expansion of macro 'flush_scheduled_work'
  flush_scheduled_work();
  ^~~~~~~~~~~~~~~~~~~~